Update naga to e98bd92 #3352
Merged
Update naga to e98bd92 #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwfitzgerald
approved these changes
Jan 5, 2023
3 tasks
JMS55
approved these changes
Jan 9, 2023
|
This test now passes wgpu/wgpu/examples/shadow/main.rs Line 856 in a06ef71 not sure why though (new version of angle?) cc @cwfitzgerald (since it was added quite recently in #3296) |
|
I don't know why either - it was failing due to validation errors stemming from #3349 and it's not like that has been fixed. |
|
What should we do for now to get this merged? I reran the workflow and it still succeeds when it shouldn't. |
We aren't quite sure why/how the latest naga changes fixed it though.
cwfitzgerald
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A routine naga update update.
I don't think there is anything to add in the changelog since naga has its own.